feat: adapt new protocol #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #585 +/- ##
==========================================
+ Coverage 66.01% 66.07% +0.05%
==========================================
Files 285 285
Lines 44358 44507 +149
==========================================
+ Hits 29285 29408 +123
- Misses 15073 15099 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ShiKaiWi
force-pushed
the
feat-adapt-new-protocol
branch
from
9956233
to
461f634
Compare
ShiKaiWi
force-pushed
the
feat-adapt-new-protocol
branch
from
48493fc
to
a6f1d38
Compare
ShiKaiWi
force-pushed
the
feat-adapt-new-protocol
branch
from
9e377e9
to
e7113ee
Compare
ShiKaiWi
force-pushed
the
feat-adapt-new-protocol
branch
2 times, most recently
from
4f00e52
to
ca4ef28
Compare
jiacai2050
reviewed
Feb 6, 2023
Rachelint
reviewed
Feb 6, 2023
ShiKaiWi
force-pushed
the
feat-adapt-new-protocol
branch
from
4a7b580
to
222ddfa
Compare
ShiKaiWi
force-pushed
the
feat-adapt-new-protocol
branch
from
1654bdf
to
b33eeb9
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: adapt to the new grpc protocol * remove enable_tenant_as_schema and add query_resp_batch_size * make convertion work * rename batch_size to min_row_per_batch * add compression threshold * adjust the query response according to the protocol * refactor the making of SqlQueryResponse * refactor convert output * add sub-section config service * rename service config options * adapt to lastest changes * add unit tests for ipc encoding/decoding * adapt to latest ceresdb-client-rs * make integration test work * update deps * update ceresdbproto git addr * fix clippy issues * fix integration test * adapt to latest rust client to make integation test work * fix failure for issue59 * compress encoded record batch in bulk rather than in stream * support compress decision in ipc.rs * add some comments * Rename Compression to CompressionMethod * fix unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Adapt to the newest protocol defined by apache/incubator-horaedb-proto#44.
What changes are included in this PR?
sql_query;metrictotable;Are there any user-facing changes?
None.
How does this change test
Add some new UT.