Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add codecov.yml to ignore some dirs that don't need code coverage #591

Merged
merged 2 commits into from
Jan 29, 2023
Merged

chore: add codecov.yml to ignore some dirs that don't need code coverage #591

merged 2 commits into from
Jan 29, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Jan 29, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Exclude some directories that don't need code coverage.

What changes are included in this PR?

Ignore following dirs in codecov:

  • "benchmarks"
  • "integration_test"
  • "meta_client"
  • "remote_engine_client"
  • "wal/src/message_queue_impl"
  • "wal/src/table_kv_impl"

Are there any user-facing changes?

No.

How does this change test

No need.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2023

Codecov Report

Merging #591 (839e9bf) into main (6d57582) will increase coverage by 3.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   62.61%   66.07%   +3.45%     
==========================================
  Files         326      284      -42     
  Lines       50232    43799    -6433     
==========================================
- Hits        31454    28938    -2516     
+ Misses      18778    14861    -3917     
Impacted Files Coverage Δ
analytic_engine/src/sst/file.rs 76.17% <0.00%> (-1.09%) ⬇️
analytic_engine/src/instance/write_worker.rs 72.41% <0.00%> (-0.77%) ⬇️
analytic_engine/src/row_iter/merge.rs 88.58% <0.00%> (-0.19%) ⬇️
benchmarks/src/config.rs
wal/src/message_queue_impl/encoding.rs
benchmarks/src/merge_sst_bench.rs
wal/src/message_queue_impl/namespace.rs
wal/src/table_kv_impl/wal.rs
remote_engine_client/src/cached_router.rs
wal/src/table_kv_impl/mod.rs
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 marked this pull request as ready for review January 29, 2023 04:26
.github/codecov.yml Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 2306aac into apache:main Jan 29, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
…age (apache#591)

* chore: add codecov.yml to ignore some dirs that don't need code coverage

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants