feat: Upgrade to Datafusion 17 #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
==========================================
- Coverage 66.01% 65.91% -0.11%
==========================================
Files 285 285
Lines 44358 44482 +124
==========================================
+ Hits 29285 29322 +37
- Misses 15073 15160 +87
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jiacai2050
requested changes
Feb 8, 2023
| @@ -282,6 +284,10 @@ impl<'a, P: MetaProvider> ContextProvider for ContextProviderAdapter<'a, P> { | |||
| ) -> Option<common_types::schema::DataType> { | |||
| None | |||
| } | |||
|
|
|||
| fn options(&self) -> &ConfigOptions { | |||
| let deadline = match state.config.config_options().get(CERESDB_REQUEST_TIMEOUT) { | ||
| Some(ScalarValue::UInt64(Some(n))) => Some(Instant::now() + Duration::from_millis(n)), | ||
| _ => None, | ||
| let ceresdb_options = state.config_options().extensions.get::<CeresdbOptions>(); |
There was a problem hiding this comment.
This couldn't be None in our case, I think we can add an assert here.
assert!(options.is_some());
chunshao90
added a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: upgrade to datafusion 17 * fix integration tests * fix integration test * make CI happy * refactor code * refactor by CR * chore: remove uesless file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Upgrade to datafusion 17 and arrow 31.
What changes are included in this PR?
Jobs left:
Changelog of those two packages:
https://github.com/apache/arrow-datafusion/blob/master/datafusion/CHANGELOG.md#1700-2023-01-27
https://github.com/apache/arrow-rs/blob/master/CHANGELOG-old.md#3100-2023-01-13
Are there any user-facing changes?
No.
How does this change test