Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make nightly image name readable #604

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Feb 2, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Current nightly docker image name is too verbose, this PR make it more readable

  • before: nightly-20230201214631-aa306ecb54a5f3863d4041182e2a46d48daad3d0
  • after: nightly-20230201-aa306ec

What changes are included in this PR?

Are there any user-facing changes?

How does this change test

@codecov-commenter
Copy link

Codecov Report

Merging #604 (84b6cd6) into main (aa306ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   65.97%   65.97%           
=======================================
  Files         285      285           
  Lines       44341    44341           
=======================================
  Hits        29255    29255           
  Misses      15086    15086           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/dockerhub-publish-nightly.yml Outdated Show resolved Hide resolved
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
@jiacai2050 jiacai2050 merged commit 639c2bd into apache:main Feb 2, 2023
@jiacai2050 jiacai2050 deleted the chore-nightly branch February 2, 2023 06:15
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: update nightly name

* Update .github/workflows/dockerhub-publish-nightly.yml

Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>

---------

Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants