Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename meta module to manifest in analytic crate #625

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Feb 9, 2023

Which issue does this PR close?

Closes #

Rationale for this change

The meta is not a good name for manifest.

What changes are included in this PR?

Rename the meta module to manifest in the analytic crate.

Are there any user-facing changes?

None.

How does this change test

Existing tests.

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Feb 9, 2023
Merged via the queue into apache:main with commit b7a5a17 Feb 9, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@ShiKaiWi ShiKaiWi deleted the chore-rename-module branch May 29, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants