Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use ConfigOptions to transfer custom settings #639

Merged
merged 1 commit into from
Feb 13, 2023
Merged

feat: use ConfigOptions to transfer custom settings #639

merged 1 commit into from
Feb 13, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Feb 13, 2023

Which issue does this PR close?

Closes #622

Rationale for this change

ConfigOptions is a structure for passing setting in datafusion, which supports passing custom setting.

What changes are included in this PR?

Use ConfigOptions to transfer custom settings.

Are there any user-facing changes?

No.

How does this change test

Add new test.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #639 (3b693d1) into main (47e4518) will increase coverage by 0.15%.
The diff coverage is 96.30%.

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   66.26%   66.42%   +0.15%     
==========================================
  Files         285      283       -2     
  Lines       44863    44259     -604     
==========================================
- Hits        29728    29397     -331     
+ Misses      15135    14862     -273     
Impacted Files Coverage Δ
analytic_engine/src/engine.rs 58.41% <ø> (-1.59%) ⬇️
analytic_engine/src/instance/mod.rs 84.21% <ø> (-0.79%) ⬇️
analytic_engine/src/lib.rs 98.76% <ø> (+0.08%) ⬆️
analytic_engine/src/sst/reader.rs 92.30% <ø> (ø)
analytic_engine/src/table/data.rs 91.64% <ø> (ø)
df_operator/src/udfs/time_bucket.rs 0.00% <0.00%> (ø)
analytic_engine/src/sst/parquet/async_reader.rs 89.22% <66.66%> (-0.27%) ⬇️
sql/src/provider.rs 35.71% <76.92%> (+0.93%) ⬆️
analytic_engine/src/setup.rs 55.76% <77.27%> (+1.22%) ⬆️
analytic_engine/src/manifest/meta_update.rs 95.97% <91.66%> (ø)
... and 73 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Feb 13, 2023
Merged via the queue into apache:main with commit acafad5 Feb 13, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ConfigOptions to transfer custom settings
3 participants