Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refacor ceresdb config #640

Merged
merged 2 commits into from
Feb 13, 2023
Merged

chore: refacor ceresdb config #640

merged 2 commits into from
Feb 13, 2023

Conversation

chunshao90
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

It is strange that DeployMode is placed in the top-level configuration, it needs to be placed in a sub-configuration.

What changes are included in this PR?

The service section in config is renamed to server.

Are there any user-facing changes?

The service section in config is renamed to server.

How does this change test

Manual testing.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #640 (2a35b48) into main (27b2c03) will decrease coverage by 0.02%.
The diff coverage is 48.48%.

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   66.41%   66.40%   -0.02%     
==========================================
  Files         283      283              
  Lines       44261    44259       -2     
==========================================
- Hits        29397    29391       -6     
- Misses      14864    14868       +4     
Impacted Files Coverage Δ
server/src/config.rs 27.82% <0.00%> (ø)
server/src/server.rs 0.00% <0.00%> (ø)
src/setup.rs 0.00% <0.00%> (ø)
sql/src/provider.rs 35.71% <76.92%> (+0.93%) ⬆️
query_engine/src/executor.rs 77.55% <100.00%> (-0.45%) ⬇️
table_engine/src/provider.rs 69.72% <100.00%> (-0.33%) ⬇️
interpreters/src/create.rs 87.50% <0.00%> (-4.17%) ⬇️
...nterpreters/src/table_manipulator/catalog_based.rs 97.22% <0.00%> (-0.93%) ⬇️
interpreters/src/tests.rs 95.72% <0.00%> (-0.72%) ⬇️
wal/src/rocks_impl/manager.rs 92.53% <0.00%> (-0.19%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Feb 13, 2023
Merged via the queue into apache:main with commit 7ece981 Feb 13, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: refacor ceresdb config

* make CI happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants