feat: map shard id to region id in manifest #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
map-shard-id-to-region-id-in-manifest
branch
from
44e31f2
to
c9b582d
Compare
ShiKaiWi
reviewed
Feb 14, 2023
Rachelint
force-pushed
the
map-shard-id-to-region-id-in-manifest
branch
from
c9b582d
to
5847258
Compare
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
==========================================
+ Coverage 66.44% 66.84% +0.40%
==========================================
Files 283 283
Lines 44286 44006 -280
==========================================
- Hits 29424 29415 -9
+ Misses 14862 14591 -271
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* expose do_snapshot method in manifest. * Force to do snapshot of manifest when closing table. * map shard id to region id in manifest. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Before, manifest is only stored in wal storage, so region id can olny be mapped to table id(otherwise, manifest of specific table will lose after being moved to new shard).
But now, if can mao shard id to region id again because we store the manifest snapshot in oss. We can force it to do snapshot before closing to solve the problem above.
What changes are included in this PR?
See title.
Are there any user-facing changes?
None.
How does this change test
Test by ut.