-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adjust configuration #649
Conversation
Codecov Report
@@ Coverage Diff @@
## main #649 +/- ##
==========================================
+ Coverage 66.84% 66.94% +0.10%
==========================================
Files 283 283
Lines 44006 43950 -56
==========================================
+ Hits 29414 29421 +7
+ Misses 14592 14529 -63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor: configuration adjustment * remove serde_derive * update some config * update config in docs * add deny_unknown_fields for top-level config * fix comments
Which issue does this PR close?
Closes #
Rationale for this change
Currently, the config of the CeresDB is casual, which needs some adjustment for elegance.
What changes are included in this PR?
path
config todata_dir
;Deployment
with theOption<ClusterDeployment>
;tracing
andlogger
under the top level;Something irrelevant to configurations:
serde_derive
which is actually re-imported byserde
crate.Are there any user-facing changes?
Config file needs updating after this PR.
How does this change test
Existing tests.