Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust configuration #649

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Feb 15, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Currently, the config of the CeresDB is casual, which needs some adjustment for elegance.

What changes are included in this PR?

  • Move the top-level config from server module to the root module;
  • Rename all the path config to data_dir;
  • Replace the Deployment with the Option<ClusterDeployment>;
  • Rename some configurations;
  • Add sub sections tracing and logger under the top level;

Something irrelevant to configurations:

  • Remove crate serde_derive which is actually re-imported by serde crate.

Are there any user-facing changes?

Config file needs updating after this PR.

How does this change test

Existing tests.

@codecov-commenter
Copy link

Codecov Report

Merging #649 (5727bbf) into main (9e7733b) will increase coverage by 0.10%.
The diff coverage is 25.05%.

❗ Current head 5727bbf differs from pull request most recent head a446d6d. Consider uploading reports for the commit a446d6d to get more accurate results

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   66.84%   66.94%   +0.10%     
==========================================
  Files         283      283              
  Lines       44006    43950      -56     
==========================================
+ Hits        29414    29421       +7     
+ Misses      14592    14529      -63     
Impacted Files Coverage Δ
analytic_engine/src/compaction/scheduler.rs 68.09% <ø> (ø)
analytic_engine/src/instance/flush_compaction.rs 66.66% <0.00%> (+0.04%) ⬆️
analytic_engine/src/sampler.rs 99.33% <0.00%> (ø)
analytic_engine/src/sst/file.rs 76.08% <ø> (-0.09%) ⬇️
analytic_engine/src/table_options.rs 64.12% <ø> (ø)
catalog_impls/src/table_based.rs 83.58% <0.00%> (ø)
catalog_impls/src/volatile.rs 0.00% <0.00%> (ø)
cluster/src/config.rs 77.77% <ø> (ø)
cluster/src/shard_tables_cache.rs 0.00% <0.00%> (ø)
common_types/src/datum.rs 50.69% <0.00%> (ø)
... and 104 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

components/logger/src/lib.rs Outdated Show resolved Hide resolved
analytic_engine/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Feb 16, 2023
Merged via the queue into apache:main with commit 8e35b4d Feb 16, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* refactor: configuration adjustment

* remove serde_derive

* update some config

* update config in docs

* add deny_unknown_fields for top-level config

* fix comments
@ShiKaiWi ShiKaiWi deleted the refactor-config-hierarchy branch May 29, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants