Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove encoder method from WalManager #661

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #

Rationale for this change

Currently, the default implementation of encoder method in WalManager trait is useless because callers can use the LogBatchEncoder directly to create such encoder.

What changes are included in this PR?

Remove the encode method defined in WalManager.

Are there any user-facing changes?

None.

How does this change test

Existing tests.

@codecov-commenter
Copy link

Codecov Report

Merging #661 (1cb9240) into main (ce9fa87) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 1cb9240 differs from pull request most recent head cae57df. Consider uploading reports for the commit cae57df to get more accurate results

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   66.94%   66.91%   -0.03%     
==========================================
  Files         283      283              
  Lines       43969    43940      -29     
==========================================
- Hits        29435    29404      -31     
- Misses      14534    14536       +2     
Impacted Files Coverage Δ
analytic_engine/src/instance/engine.rs 64.03% <ø> (ø)
wal/src/lib.rs 100.00% <ø> (ø)
wal/src/manager.rs 90.43% <ø> (-0.12%) ⬇️
analytic_engine/src/instance/alter.rs 95.19% <100.00%> (-0.28%) ⬇️
analytic_engine/src/instance/write.rs 87.05% <100.00%> (-0.32%) ⬇️
analytic_engine/src/manifest/details.rs 95.93% <100.00%> (-0.03%) ⬇️
components/skiplist/src/list.rs 98.87% <0.00%> (-0.23%) ⬇️
wal/src/rocks_impl/manager.rs 92.53% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Feb 23, 2023
Merged via the queue into apache:main with commit 698eec7 Feb 23, 2023
@ShiKaiWi ShiKaiWi deleted the refactor-wal-manager branch February 23, 2023 08:35
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* refactor: remove encoder method from WalManager

* chore: remove GetLogBatchEncoder error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants