Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add partition_table test in integration_test #668

Merged
merged 2 commits into from
Feb 28, 2023
Merged

test: add partition_table test in integration_test #668

merged 2 commits into from
Feb 28, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Feb 27, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Add partition_table test in integration_test.

What changes are included in this PR?

Add partition_table test in integration_test.

Are there any user-facing changes?

No.

How does this change test

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #668 (5e56660) into main (9e06dcc) will increase coverage by 0.27%.
The diff coverage is 31.00%.

❗ Current head 5e56660 differs from pull request most recent head d5efb7e. Consider uploading reports for the commit d5efb7e to get more accurate results

@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
+ Coverage   67.28%   67.55%   +0.27%     
==========================================
  Files         283      281       -2     
  Lines       44491    44296     -195     
==========================================
- Hits        29935    29926       -9     
+ Misses      14556    14370     -186     
Impacted Files Coverage Δ
analytic_engine/src/instance/write.rs 86.95% <ø> (-0.10%) ⬇️
analytic_engine/src/lib.rs 98.76% <ø> (ø)
common_types/src/lib.rs 100.00% <ø> (ø)
common_util/src/lib.rs 100.00% <ø> (ø)
server/src/grpc/remote_engine_service/mod.rs 0.00% <0.00%> (ø)
table_engine/src/remote/model.rs 0.00% <0.00%> (ø)
analytic_engine/src/sst/parquet/meta_data.rs 87.35% <100.00%> (+3.73%) ⬆️
components/parquet_ext/src/prune/min_max.rs 94.04% <100.00%> (+1.14%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 marked this pull request as ready for review February 27, 2023 12:46
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang added this pull request to the merge queue Feb 28, 2023
Merged via the queue into apache:main with commit 0fc481f Feb 28, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* test: add partition_table test in integration_test

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants