fix: can't recognize aliyun oss NotFoundError when load manifest #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelLeeHZ
reviewed
Mar 1, 2023
Rachelint
reviewed
Mar 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 67.54% 67.54% -0.01%
==========================================
Files 281 281
Lines 44302 44309 +7
==========================================
+ Hits 29925 29927 +2
- Misses 14377 14382 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…che#678) * fix: can't recognize aliyun oss NotFoundError when load manifest * chore: fix wrong or operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Currently, the not found error won't be thrown when access an object file in the aliyun oss by oss sdk, leading to possible panic when restarting.
What changes are included in this PR?
Take a workaround way (check whether the error message contains '404' or 'not found') to detect the not found error.
Are there any user-facing changes?
None.
How does this change test
Manual test.