Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid file purge when they are used in queries #699

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 6, 2023

Which issue does this PR close?

Closes #427 #534

Rationale for this change

What changes are included in this PR?

  • Hold sst reference in merge/chain iterator, so sst cannot be pushed to purge queue when there are queries.

Are there any user-facing changes?

No

How does this change test

CI

@jiacai2050 jiacai2050 changed the title fix: file purge when query same file fix: avoid file purge when they are used in queries Mar 6, 2023
@ShiKaiWi ShiKaiWi enabled auto-merge March 7, 2023 09:50
@codecov-commenter
Copy link

Codecov Report

Merging #699 (253b4d0) into main (f79890b) will increase coverage by 0.82%.
The diff coverage is 88.88%.

❗ Current head 253b4d0 differs from pull request most recent head 6d366f2. Consider uploading reports for the commit 6d366f2 to get more accurate results

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
+ Coverage   67.55%   68.38%   +0.82%     
==========================================
  Files         281      281              
  Lines       44343    44351       +8     
==========================================
+ Hits        29956    30328     +372     
+ Misses      14387    14023     -364     
Impacted Files Coverage Δ
analytic_engine/src/row_iter/chain.rs 56.56% <50.00%> (-0.06%) ⬇️
analytic_engine/src/row_iter/merge.rs 89.63% <100.00%> (+0.62%) ⬆️
analytic_engine/src/sst/file.rs 87.36% <100.00%> (+10.19%) ⬆️
components/skiplist/src/list.rs 98.87% <0.00%> (-0.23%) ⬇️
analytic_engine/src/setup.rs 56.63% <0.00%> (+0.32%) ⬆️
analytic_engine/src/table/version.rs 94.27% <0.00%> (+0.58%) ⬆️
analytic_engine/src/compaction/mod.rs 83.45% <0.00%> (+1.40%) ⬆️
analytic_engine/src/compaction/scheduler.rs 70.44% <0.00%> (+2.35%) ⬆️
analytic_engine/src/sst/parquet/meta_data.rs 90.90% <0.00%> (+3.55%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 8, 2023
Merged via the queue into apache:main with commit c64a370 Mar 8, 2023
@jiacai2050 jiacai2050 deleted the fix-file-purge branch March 27, 2023 06:06
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* fix file purge when query same file

* fix CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_table_compact_current panic sometimes in CI
3 participants