Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove custom oss impl #720

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 9, 2023

Which issue does this PR close?

Closes #608, close #396

Rationale for this change

Since OSS is S3-compatible, so we can access OSS via S3 client directly.

What changes are included in this PR?

  • Use S3 client in object_store crate to access OSS

Are there any user-facing changes?

No

How does this change test

Manually

@jiacai2050 jiacai2050 marked this pull request as ready for review March 10, 2023 04:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #720 (6ed6faa) into main (49fadb1) will increase coverage by 0.08%.
The diff coverage is 19.83%.

❗ Current head 6ed6faa differs from pull request most recent head 09268a4. Consider uploading reports for the commit 09268a4 to get more accurate results

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   68.18%   68.26%   +0.08%     
==========================================
  Files         287      287              
  Lines       45124    45057      -67     
==========================================
- Hits        30766    30759       -7     
+ Misses      14358    14298      -60     
Impacted Files Coverage Δ
analytic_engine/src/setup.rs 56.00% <0.00%> (-0.42%) ⬇️
server/src/config.rs 37.64% <0.00%> (-0.45%) ⬇️
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/write.rs 37.32% <0.00%> (-1.67%) ⬇️
server/src/handlers/prom.rs 68.44% <0.00%> (+0.16%) ⬆️
server/src/server.rs 0.00% <0.00%> (ø)
components/object_store/src/aliyun.rs 45.16% <42.10%> (+24.92%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 10, 2023
Merged via the queue into apache:main with commit a803efc Mar 10, 2023
@jiacai2050 jiacai2050 deleted the refactor-oss branch March 10, 2023 06:56
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* refactor: remove custom oss impl

* fix endpoint

* add region issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use OpenDAL to access object store Support multipart upload sst file for aliyun oss
3 participants