Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add influxdb write #723

Merged
merged 7 commits into from
Mar 13, 2023
Merged

feat: add influxdb write #723

merged 7 commits into from
Mar 13, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 10, 2023 •
edited

Which issue does this PR close?

Part of #682

Rationale for this change

What changes are included in this PR?

  • Refactor influxdb http handler to make it more modular
  • Support influxdb line protocol write(convert to gRPC write internal)

Are there any user-facing changes?

No

How does this change test

CI

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023 •
edited

Codecov Report

Merging #723 (05195b0) into main (a803efc) will decrease coverage by 0.02%.
The diff coverage is 60.65%.

❗ Current head 05195b0 differs from pull request most recent head e88784f. Consider uploading reports for the commit e88784f to get more accurate results

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   68.26%   68.25%   -0.02%     
==========================================
  Files         287      288       +1     
  Lines       45058    45335     +277     
==========================================
+ Hits        30761    30944     +183     
- Misses      14297    14391      +94
Impacted Files Coverage Δ
server/src/handlers/error.rs 0.00% <ø> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
server/src/handlers/influxdb.rs 67.02% <67.02%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jiacai2050 jiacai2050 marked this pull request as ready for review March 13, 2023 06:47
ShiKaiWi
ShiKaiWi reviewed Mar 13, 2023
View reviewed changes
integration_tests/src/database.rs Show resolved Hide resolved
server/src/handlers/error.rs Outdated Show resolved Hide resolved
server/src/handlers/influxdb.rs Show resolved Hide resolved
ShiKaiWi
ShiKaiWi approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 13, 2023
Merged via the queue into apache:main with commit 8837aa6 Mar 13, 2023
@jiacai2050 jiacai2050 deleted the feat-influxdb-write branch March 13, 2023 09:57
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
feat: add influxdb write (apache#723)
616405d 
* refactor: add influxdb module

* add convert write request

* impl write handler

* merge field group for same series

* add convert unittest

* fix CR

* fix naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiacai2050 @codecov-commenter @ShiKaiWi