Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce proxy module #732

Merged
merged 17 commits into from
Mar 20, 2023
Merged

feat: introduce proxy module #732

merged 17 commits into from
Mar 20, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Mar 14, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Introduce proxy module. Refer to #681 .

What changes are included in this PR?

  • Introduce proxy module.
  • Impl storage_service with proxy.
  • Support forwarding stream query.

Are there any user-facing changes?

No.

How does this change test

Integration test.

* impl route service with proxy

* impl write service with proxy

* remove forward module in proxy

* refactor code

* add tests in write
* refactor: refactor proxy module

* cargo fmt

* refactor by CR
* feat: impl prom query with proxy

* refactor code
* feat: impl stream query with proxy

* refactor by CR
@chunshao90 chunshao90 marked this pull request as ready for review March 16, 2023 08:25
docs/minimal.toml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #732 (48d1b54) into main (d71e875) will decrease coverage by 0.41%.
The diff coverage is 20.24%.

❗ Current head 48d1b54 differs from pull request most recent head d9b9aa7. Consider uploading reports for the commit d9b9aa7 to get more accurate results

@@            Coverage Diff             @@
##             main     #732      +/-   ##
==========================================
- Coverage   68.49%   68.08%   -0.41%     
==========================================
  Files         292      295       +3     
  Lines       45413    45628     +215     
==========================================
- Hits        31104    31066      -38     
- Misses      14309    14562     +253     
Impacted Files Coverage Δ
analytic_engine/src/table/partition.rs 0.00% <0.00%> (ø)
server/src/config.rs 37.64% <ø> (ø)
server/src/grpc/metrics.rs 0.00% <0.00%> (ø)
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/error.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/header.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/mod.rs 0.00% <0.00%> (ø)
server/src/handlers/influxdb.rs 67.02% <0.00%> (ø)
server/src/handlers/prom.rs 68.44% <0.00%> (ø)
server/src/lib.rs 100.00% <ø> (ø)
... and 12 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

server/src/proxy/error.rs Outdated Show resolved Hide resolved
server/src/proxy/mod.rs Show resolved Hide resolved
docs/minimal.toml Outdated Show resolved Hide resolved
server/src/proxy/forward.rs Outdated Show resolved Hide resolved
server/src/proxy/error.rs Show resolved Hide resolved
server/src/proxy/grpc/sql_query.rs Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 added this pull request to the merge queue Mar 20, 2023
@chunshao90 chunshao90 merged commit 556a15a into apache:main Mar 20, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: introduce proxy module (apache#715)

* impl route service with proxy

* impl write service with proxy

* remove forward module in proxy

* refactor code

* add tests in write

* feat: impl query with proxy (apache#717)

* refactor: refactor proxy module (apache#726)

* refactor: refactor proxy module

* cargo fmt

* refactor by CR

* Feat proxy prom query (apache#727)

* feat: impl prom query with proxy

* refactor code

* feat: impl stream write with proxy (apache#737)

* feat: impl stream query with proxy (apache#742)

* feat: impl stream query with proxy

* refactor by CR

* feat: introduce proxy module

* refactor code

* add header in storage service

* feat: impl storage service with proxy

* make CI happy

* refactor code

* refactor code

* refactor by CR

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants