Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove replace table level metrics with aggregate metrics #740

Merged
merged 15 commits into from
Mar 20, 2023

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #718

Rationale for this change

Refer to #718

What changes are included in this PR?

  • Replace the table-level metrics with aggregate metrics

Are there any user-facing changes?

The metrics changes.

How does this change test

Manually.

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Merging #740 (7b7cb74) into main (c0494fe) will decrease coverage by 0.03%.
The diff coverage is 58.59%.

❗ Current head 7b7cb74 differs from pull request most recent head 1d51e72. Consider uploading reports for the commit 1d51e72 to get more accurate results

@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   68.47%   68.44%   -0.03%     
==========================================
  Files         294      292       -2     
  Lines       45678    45319     -359     
==========================================
- Hits        31278    31019     -259     
+ Misses      14400    14300     -100     
Impacted Files Coverage Δ
analytic_engine/src/table/partition.rs 0.00% <0.00%> (ø)
cluster/src/config.rs 75.00% <0.00%> (ø)
common_util/src/config.rs 87.02% <0.00%> (ø)
components/logger/src/lib.rs 27.98% <0.00%> (ø)
components/tracing_util/src/logging.rs 0.00% <0.00%> (ø)
query_engine/src/config.rs 83.33% <0.00%> (ø)
router/src/rule_based.rs 0.00% <0.00%> (ø)
server/src/config.rs 37.64% <0.00%> (ø)
server/src/grpc/forward.rs 79.48% <0.00%> (ø)
server/src/grpc/meta_event_service/mod.rs 0.00% <0.00%> (ø)
... and 24 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 20, 2023
@ShiKaiWi ShiKaiWi merged commit 624c846 into apache:main Mar 20, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
…he#740)

* feat: remove metrics on table level

* expose the log of ceresdb in integration tests

* upload cluster outlog

* redirect logs from ceresdb container in integration tests

* always redirect logs

* refactor the integration tests of cluster env

* refactor integration tests

* fix recursive call

* fix integration tests

* adjust ceresmeta bin path

* fix panic for partition table metrics

* update standalone config

* update root Makefile

* fix ci

* only clone the lastest commit of ceresmeta
@ShiKaiWi ShiKaiWi deleted the fix-718 branch May 29, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the metrics
4 participants