feat: return error while encountering unsupport from in influxql #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #745 +/- ##
==========================================
+ Coverage 68.43% 68.49% +0.05%
==========================================
Files 294 292 -2
Lines 45712 45401 -311
==========================================
- Hits 31284 31096 -188
+ Misses 14428 14305 -123
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jiacai2050
reviewed
Mar 16, 2023
jiacai2050
reviewed
Mar 16, 2023
jiacai2050
reviewed
Mar 16, 2023
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…che#745) * return error while encountering unsupport from in influxql. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Now, we are unable to support from multiple measurements in influxql.
So, we should check and reject them.
What changes are included in this PR?
See title.
Are there any user-facing changes?
Will get error information while pass the influxql which selects from multiple measurement.
How does this change test
Test by ut.