Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto add column #749

Merged
merged 21 commits into from
Mar 22, 2023
Merged

feat: auto add column #749

merged 21 commits into from
Mar 22, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Mar 20, 2023

Which issue does this PR close?

Closes #634

Rationale for this change

Refer to #634

What changes are included in this PR?

  • Support auto create new columns.
  • Add auto create new columns in test of golang sdk.

Are there any user-facing changes?

How does this change test

Add auto create new columns in test of golang sdk.

@chunshao90 chunshao90 changed the title Feat auto add column feat: auto add column Mar 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #749 (798d3c9) into main (d71e875) will decrease coverage by 0.48%.
The diff coverage is 18.86%.

❗ Current head 798d3c9 differs from pull request most recent head d1390b2. Consider uploading reports for the commit d1390b2 to get more accurate results

@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
- Coverage   68.49%   68.01%   -0.48%     
==========================================
  Files         292      295       +3     
  Lines       45413    45664     +251     
==========================================
- Hits        31104    31060      -44     
- Misses      14309    14604     +295     
Impacted Files Coverage Δ
analytic_engine/src/table/partition.rs 0.00% <0.00%> (ø)
server/src/config.rs 37.64% <ø> (ø)
server/src/grpc/metrics.rs 0.00% <0.00%> (ø)
server/src/grpc/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/error.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/header.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/mod.rs 0.00% <0.00%> (ø)
server/src/handlers/influxdb.rs 67.02% <0.00%> (ø)
server/src/handlers/prom.rs 68.44% <0.00%> (ø)
server/src/lib.rs 100.00% <ø> (ø)
... and 13 more

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 marked this pull request as ready for review March 20, 2023 13:14
integration_tests/sdk/go/main.go Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/write.rs Show resolved Hide resolved
server/src/proxy/grpc/write.rs Show resolved Hide resolved
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 22, 2023
@jiacai2050 jiacai2050 merged commit be9f50e into apache:main Mar 22, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* feat: introduce proxy module (apache#715)

* impl route service with proxy

* impl write service with proxy

* remove forward module in proxy

* refactor code

* add tests in write

* feat: impl query with proxy (apache#717)

* refactor: refactor proxy module (apache#726)

* refactor: refactor proxy module

* cargo fmt

* refactor by CR

* Feat proxy prom query (apache#727)

* feat: impl prom query with proxy

* refactor code

* feat: impl stream write with proxy (apache#737)

* feat: impl stream query with proxy (apache#742)

* feat: impl stream query with proxy

* refactor by CR

* feat: introduce proxy module

* refactor code

* add header in storage service

* feat: impl storage service with proxy

* make CI happy

* refactor code

* refactor code

* refactor by CR

* feat: automatically create non-existent columns during insertion

* test: add autoAddColumns test in go sdk

* refactor code

* refactor by CR

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports automatic field creation
3 participants