Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make influxql query interface compatible with influxdb1.8 #773

Merged
merged 8 commits into from
Mar 28, 2023

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

See title.
And after doing this, we can connect ceresdb to grafana with inluxdb protocol.

What changes are included in this PR?

See title.

Are there any user-facing changes?

Can use the same influxdb1.8 compatible query api to query data from ceresdb.

How does this change test

Test manually.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #773 (93cb692) into main (32bd51e) will decrease coverage by 0.18%.
The diff coverage is 9.34%.

❗ Current head 93cb692 differs from pull request most recent head 979dc3f. Consider uploading reports for the commit 979dc3f to get more accurate results

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   68.48%   68.31%   -0.18%     
==========================================
  Files         296      296              
  Lines       46645    46735      +90     
==========================================
- Hits        31946    31926      -20     
- Misses      14699    14809     +110     
Impacted Files Coverage Δ
server/src/handlers/query.rs 0.00% <ø> (ø)
server/src/http.rs 0.00% <0.00%> (ø)
server/src/handlers/influxdb.rs 69.35% <11.36%> (-8.04%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Rachelint Rachelint force-pushed the make-iql-query-interface-compatible branch from bc8d078 to f75d120 Compare March 27, 2023 09:40
@Rachelint Rachelint marked this pull request as ready for review March 27, 2023 09:44
@jiacai2050 jiacai2050 self-requested a review March 27, 2023 09:48
@Rachelint Rachelint force-pushed the make-iql-query-interface-compatible branch 4 times, most recently from 9ace7ba to e62958f Compare March 27, 2023 10:21
@Rachelint Rachelint force-pushed the make-iql-query-interface-compatible branch from e62958f to b0ee33b Compare March 27, 2023 10:21
server/src/handlers/influxdb.rs Outdated Show resolved Hide resolved
server/src/handlers/influxdb.rs Outdated Show resolved Hide resolved
@Rachelint Rachelint force-pushed the make-iql-query-interface-compatible branch from aea6ded to faab1d4 Compare March 28, 2023 05:44
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint force-pushed the make-iql-query-interface-compatible branch from b34f206 to ecfd488 Compare March 28, 2023 06:23
@Rachelint Rachelint force-pushed the make-iql-query-interface-compatible branch from ecfd488 to 979dc3f Compare March 28, 2023 06:47
@jiacai2050 jiacai2050 added this pull request to the merge queue Mar 28, 2023
Merged via the queue into apache:main with commit 818b025 Mar 28, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
…he#773)

* make query interface compatible to influxdb1.8.

* make query by influxql support both get and post.

* fix influxql integration test.

* merge influxdb_write and influxdb_query to influxdb_api.

* remove the future support comment of `chunked`.

* unify Precision and Epoch.

* refactor the WriteRequest of influxdb api.

* solve overflow in Precision::normalize.
@Rachelint Rachelint deleted the make-iql-query-interface-compatible branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants