Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default schema config #782

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Mar 28, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Simplify schema config setting. If we don't provide a define one, we need to set schema config one by one, something like

[[cluster_deployment.topology.schema_shards]]
schema = 'public_0'
default_timestamp_column_name = 'time'
[[cluster_deployment.topology.schema_shards.shard_views]]
shard_id = 0
[cluster_deployment.topology.schema_shards.shard_views.endpoint]
addr = '127.0.0.1'
port = 8831
[[cluster_deployment.topology.schema_shards.shard_views]]
shard_id = 1
[cluster_deployment.topology.schema_shards.shard_views.endpoint]
addr = '127.0.0.1'
port = 8831

This is very inconvient.

What changes are included in this PR?

  • Add default schema config in server
[server.default_schema_config]
default_timestamp_column_name = "time"
  • Update bind_addr to 127.0.0.1, which is more safe than before.

Are there any user-facing changes?

No

How does this change test

Manully

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Mar 28, 2023
Merged via the queue into apache:main with commit b83f6b6 Mar 28, 2023
@jiacai2050 jiacai2050 deleted the feat-default-conf branch March 28, 2023 09:36
jiacai2050 added a commit to jiacai2050/incubator-horaedb that referenced this pull request Mar 28, 2023
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants