Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl get_table_info in remote_engine_client #798

Merged
merged 1 commit into from
Mar 31, 2023
Merged

feat: impl get_table_info in remote_engine_client #798

merged 1 commit into from
Mar 31, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Mar 30, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Impl get_table_info in remote_engine_client.

What changes are included in this PR?

Impl get_table_info in remote_engine_client.

Are there any user-facing changes?

No.

How does this change test

Testing will be conducted with the partition table, and it will be used internally by the engine without affecting external users for the time being.

@chunshao90 chunshao90 marked this pull request as ready for review March 30, 2023 13:28
@codecov-commenter
Copy link

Codecov Report

Merging #798 (9ae6848) into main (6205de9) will decrease coverage by 0.17%.
The diff coverage is 3.52%.

❗ Current head 9ae6848 differs from pull request most recent head 6bf8ed9. Consider uploading reports for the commit 6bf8ed9 to get more accurate results

@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
- Coverage   68.30%   68.13%   -0.17%     
==========================================
  Files         295      295              
  Lines       46702    46817     +115     
==========================================
+ Hits        31898    31899       +1     
- Misses      14804    14918     +114     
Impacted Files Coverage Δ
common_types/src/schema.rs 96.50% <ø> (ø)
interpreters/src/show.rs 28.67% <0.00%> (-3.12%) ⬇️
server/src/grpc/metrics.rs 0.00% <0.00%> (ø)
server/src/grpc/remote_engine_service/mod.rs 0.00% <0.00%> (ø)
server/src/grpc/storage_service/mod.rs 0.00% <0.00%> (ø)
sql/src/influxql/planner.rs 51.00% <0.00%> (-4.44%) ⬇️
table_engine/src/remote/mod.rs 0.00% <ø> (ø)
table_engine/src/remote/model.rs 0.00% <0.00%> (ø)
server/src/handlers/influxdb.rs 69.44% <100.00%> (+0.08%) ⬆️
sql/src/plan.rs 93.93% <100.00%> (+0.18%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 31, 2023
Merged via the queue into apache:main with commit c083f51 Mar 31, 2023
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants