Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: query partition table with proxy in grpc service #802

Merged
merged 10 commits into from
Apr 11, 2023
Merged

feat: query partition table with proxy in grpc service #802

merged 10 commits into from
Apr 11, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Apr 3, 2023 •
edited

Which issue does this PR close?

Closes #

Rationale for this change

Support query partition table with proxy in grpc sql query.

What changes are included in this PR?

  • Open partition table in proxy.
  • When creating a partition table, the partition table information is not persistently stored in the manifest.

Are there any user-facing changes?

No.

How does this change test

Manual testing and CI.

@chunshao90 chunshao90 changed the title Feat partition table in proxy feat: support partition table with proxy Apr 3, 2023
@chunshao90 chunshao90 mentioned this pull request Apr 3, 2023
Closed
@chunshao90 chunshao90 marked this pull request as ready for review April 3, 2023 13:20
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023 •
edited

Codecov Report

Merging #802 (b281d61) into main (796c209) will decrease coverage by 0.39%.
The diff coverage is 27.72%.

❗ Current head b281d61 differs from pull request most recent head 2e9c523. Consider uploading reports for the commit 2e9c523 to get more accurate results

@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   67.95%   67.56%   -0.39%     
==========================================
  Files         300      303       +3     
  Lines       47314    47529     +215     
==========================================
- Hits        32151    32114      -37     
- Misses      15163    15415     +252
Impacted Files Coverage Δ
analytic_engine/src/instance/create.rs 92.47% <ø> (-0.09%) ⬇️
analytic_engine/src/instance/mod.rs 83.33% <ø> (ø)
analytic_engine/src/instance/open.rs 80.57% <ø> (-0.12%) ⬇️
analytic_engine/src/setup.rs 56.34% <ø> (+0.02%) ⬆️
analytic_engine/src/table/data.rs 91.42% <ø> (+0.16%) ⬆️
analytic_engine/src/table/metrics.rs 92.02% <ø> (+7.36%) ⬆️
analytic_engine/src/table/mod.rs 83.69% <0.00%> (ø)
catalog_impls/src/volatile.rs 0.00% <0.00%> (ø)
cluster/src/cluster_impl.rs 0.00% <0.00%> (ø)
partition_table_engine/src/error.rs 0.00% <0.00%> (ø)
... and 23 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 changed the title feat: support partition table with proxy feat: query partition table with proxy in grpc service Apr 4, 2023
@jiacai2050 jiacai2050 self-requested a review April 4, 2023 11:21
ShiKaiWi
ShiKaiWi reviewed Apr 10, 2023
View reviewed changes
server/src/proxy/grpc/route.rs Outdated Show resolved Hide resolved
sql/src/frontend.rs Outdated Show resolved Hide resolved
table_engine/src/engine.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 requested changes Apr 10, 2023
View reviewed changes
server/src/grpc/meta_event_service/mod.rs Outdated Show resolved Hide resolved
server/src/proxy/forward.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/sql_query.rs Outdated Show resolved Hide resolved
server/src/proxy/mod.rs Outdated Show resolved Hide resolved
catalog/src/schema.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi reviewed Apr 10, 2023
View reviewed changes
catalog/src/schema.rs Show resolved Hide resolved
catalog_impls/src/volatile.rs Outdated Show resolved Hide resolved
router/src/cluster_based.rs Show resolved Hide resolved
server/src/grpc/meta_event_service/mod.rs Outdated Show resolved Hide resolved
server/src/proxy/grpc/sql_query.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi reviewed Apr 11, 2023
View reviewed changes
meta_client/src/types.rs Outdated Show resolved Hide resolved
router/src/cluster_based.rs Outdated Show resolved Hide resolved
router/src/cluster_based.rs Outdated Show resolved Hide resolved
router/src/cluster_based.rs Outdated Show resolved Hide resolved
ShiKaiWi
ShiKaiWi approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jiacai2050
jiacai2050 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 added this pull request to the merge queue Apr 11, 2023
Merged via the queue into apache:main with commit 72e7d82 Apr 11, 2023
4 of 5 checks passed
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@chunshao90
feat: query partition table with proxy in grpc service (apache#802)
3efa221 
* feat: support partition table with proxy

* refactor code

* feat: introduce partition table engine

* test: modify integration_tests/cases/env/cluster/05_ddl/partition_table.result

* refactor code

* refactor by CR

* refactor by CR

* refactor by CR

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chunshao90 @codecov-commenter @jiacai2050 @ShiKaiWi