Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make tsbs more configurable #805

Merged
merged 4 commits into from
Apr 3, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Apr 3, 2023

Which issue does this PR close?

Closes #

Rationale for this change

In order to prepare for nightly running tsbs on a server, the run-tsbs script should more configurable.

What changes are included in this PR?

  • Expose more config, including log directory, ceresdb grpc addr and so on;
  • Record the ceresdb pid and kill it after finished;

Are there any user-facing changes?

None.

How does this change test

It has been used on the https://github.com/ShiKaiWi/ceresdb-benchmark

@ShiKaiWi ShiKaiWi requested a review from jiacai2050 April 3, 2023 10:09
@ShiKaiWi ShiKaiWi changed the title Refactor tsbs running refactor: make tsbs more configurable Apr 3, 2023
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scripts/run-tsbs.sh Outdated Show resolved Hide resolved
@ShiKaiWi ShiKaiWi added this pull request to the merge queue Apr 3, 2023
Merged via the queue into apache:main with commit db8ad4b Apr 3, 2023
4 of 5 checks passed
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* refactor: make tsbs more configurable

* feat: run tsbs after building ceresdb-server

* fix: build release ceresdb rather than slim-release for tsbs

* fix: avoid `rm -rf` in run-tsbs.sh
@ShiKaiWi ShiKaiWi deleted the refactor-tsbs-running branch May 29, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants