Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: influxql support fill syntax #824

Merged
merged 2 commits into from
Apr 11, 2023
Merged

feat: influxql support fill syntax #824

merged 2 commits into from
Apr 11, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Apr 11, 2023 •
edited

Which issue does this PR close?

Closes #

Rationale for this change

Fill syntax is part of influxql.

What changes are included in this PR?

  • Bump iox, which contains changes to support ms time unit
  • Register GapFill datafusion extension

Are there any user-facing changes?

Yes, fill is supported, like this:

SELECT count(water_level) FROM "h2o_feet"
where time < 1439828400000ms
group by location, time(5m) fill(1)

And we can query influxql in grafana directly.

image

How does this change test

New integration testcase

Rachelint
Rachelint approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Apr 11, 2023
Merged via the queue into apache:main with commit 2681ec6 Apr 11, 2023
4 of 5 checks passed
@jiacai2050 jiacai2050 deleted the influxql-fill branch April 11, 2023 07:55
@jiacai2050 jiacai2050 mentioned this pull request Apr 12, 2023
Closed
2 tasks
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
feat: influxql support fill syntax (apache#824)
4e9d2d6 
* feat: influxql support fill

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiacai2050 @Rachelint