Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary deps #838

Merged
merged 3 commits into from
Apr 13, 2023
Merged

chore: remove unnecessary deps #838

merged 3 commits into from
Apr 13, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Apr 13, 2023 •
edited

Which issue does this PR close?

Closes #

Rationale for this change

Some deps are unnecessary.

What changes are included in this PR?

  • Remove direct dep for datafusion_expr, datafusion-optimizer. Those crates are already reexport in datafusion itself.
// re-export DataFusion crates
pub use datafusion_common as common;
pub use datafusion_common::config;
pub use datafusion_expr as logical_expr;
pub use datafusion_optimizer as optimizer;
pub use datafusion_physical_expr as physical_expr;
pub use datafusion_row as row;
pub use datafusion_sql as sql;

#[cfg(feature = "jit")]
pub use datafusion_jit as jit;
  • Replace iox with influxql

Are there any user-facing changes?

NO

How does this change test

CI

chunshao90
chunshao90 approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rachelint
Rachelint approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 added this pull request to the merge queue Apr 13, 2023
Merged via the queue into apache:main with commit 9c2555e Apr 13, 2023
4 checks passed
@jiacai2050 jiacai2050 deleted the clean-dep branch April 13, 2023 08:27
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
chore: remove unnecessary deps (apache#838)
9897674 
* chore: remove unnecessary deps

* remove iox dep

* fix conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunshao90 chunshao90 chunshao90 approved these changes

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiacai2050 @chunshao90 @Rachelint