feat: compaction support different level #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
feat-add-level1
branch
from
f163436
to
cbf693c
Compare
jiacai2050
force-pushed
the
feat-add-level1
branch
from
0b03376
to
4c53437
Compare
jiacai2050
force-pushed
the
feat-add-level1
branch
from
4c53437
to
a5804f9
Compare
jiacai2050
force-pushed
the
feat-add-level1
branch
from
3cf36eb
to
6e95f50
Compare
jiacai2050
force-pushed
the
feat-add-level1
branch
from
4eb8eb0
to
c89137e
Compare
jiacai2050
commented
Apr 20, 2023
ShiKaiWi
reviewed
Apr 20, 2023
Rachelint
reviewed
Apr 21, 2023
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: add level 1 sst file * add more comments for compaction tests * wait manual compaction finish * fix CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Currently all sst are in level0, and we find that when flush memtable-> sst0,
build parquet filter cost lots of CPU, which affect write throughout indirectly.
What changes are included in this PR?
Introduce SST at level 1, this is how data is moved between different components:
Flush memtable will only output sst at level 0, and it will skip parquet filter building.
Fow now, compaction strategy is same for 0->1 and 1->1, later we need to investigate different strategy for them.
Are there any user-facing changes?
No
How does this change test
CI