Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename module sql to query_frontend #849

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Sql module not only include parser and planner about sql, but more like promql and influxql, so I think naming it query_frontend may be more suitable.

What changes are included in this PR?

Rename the sql module.

Are there any user-facing changes?

None.

How does this change test

Not need.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint added this pull request to the merge queue Apr 19, 2023
Merged via the queue into apache:main with commit 42d0c97 Apr 19, 2023
5 checks passed
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* rename module `sql` to `query_frontend`.

* redirect ceresdbproto's path to crates.io.
@Rachelint Rachelint deleted the rename-sql-to-query-frontend branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants