refactor: shard lock module #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
refactor-shard-lock
branch
2 times, most recently
from
a66b807
to
80b0efa
Compare
ShiKaiWi
force-pushed
the
refactor-shard-lock
branch
from
80b0efa
to
a1bcd3b
Compare
jiacai2050
reviewed
Apr 25, 2023
jiacai2050
reviewed
Apr 25, 2023
Rachelint
reviewed
Apr 25, 2023
ShiKaiWi
force-pushed
the
refactor-shard-lock
branch
from
0f6486d
to
8c8c9d0
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* refactor: shard lock module * chore: classify whether the lock release is in purpose * fix: allow ceresmeta restarting * fix: wait background keepalive exit before next grant * feat: support retry for keeping alive * chore: rename mutex and rwlock * fix: allow exit when schedule next keepalive * feat: determine rpc_time by ttl * chore: comments to explain the retry logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
There are some issues remaining in the #706.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Existing tests.