Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: proxy as a separate module #865

Merged
merged 1 commit into from
Apr 28, 2023
Merged

chore: proxy as a separate module #865

merged 1 commit into from
Apr 28, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Apr 28, 2023

Which issue does this PR close?

Closes #

Rationale for this change

The proxy module code is getting more and more complex, and it is logically inconsistent with the server module, so proxy is defined as a separate module.

What changes are included in this PR?

  • Proxy as a separate module.

Are there any user-facing changes?

No.

How does this change test

CI.

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chunshao.rcs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chunshao90 chunshao90 changed the title chore: proxy as a separate mod chore: proxy as a separate module Apr 28, 2023
@chunshao90 chunshao90 marked this pull request as ready for review April 28, 2023 05:58
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 30ba19c into apache:main Apr 28, 2023
5 checks passed
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants