Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify the PR tmpl #885

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

ShiKaiWi
Copy link
Member

Which issue does this PR close?

Closes #

Rationale for this change

To utilize the PR description for commit message, the description should be made more concise.

What changes are included in this PR?

Make the PR tmpl more concise.

Are there any user-facing changes?

None.

How does this change test

No need.

@Rachelint
Copy link
Contributor

Rachelint commented May 17, 2023

I think maybe Rationale for this change can be removed?
How about just introduce the changes in pr description? And we left the rationale in related issue if it is a big work that we should make detail design before coding.

@jiacai2050
Copy link
Contributor

I think maybe Rationale for this change can be removed?

Agree, I think following are most important

## Which issue does this PR close?
## What changes are included in this PR?
## How does this change test

@ShiKaiWi
Copy link
Member Author

I think maybe Rationale for this change can be removed?

Agree, I think following are most important

## Which issue does this PR close?
## What changes are included in this PR?
## How does this change test

These subtitles seem verbose if they are put in the git message. Shall we make them more concise?

## Related Issues
## Detailed Changes
## Test Plan

@Rachelint
Copy link
Contributor

I think maybe Rationale for this change can be removed?

Agree, I think following are most important

## Which issue does this PR close?
## What changes are included in this PR?
## How does this change test

These subtitles seem verbose if they are put in the git message. Shall we make them more concise?

## Related Issues
## Detailed Changes
## Test Plan

Seems ok.

@ShiKaiWi ShiKaiWi merged commit 7419d0c into apache:main May 22, 2023
1 check passed
@ShiKaiWi ShiKaiWi deleted the simplify-pr-tmpl branch May 22, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants