Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: proxy write and route #889

Merged
merged 3 commits into from
May 12, 2023
Merged

refactor: proxy write and route #889

merged 3 commits into from
May 12, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented May 11, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Refactor the proxy module to remove some duplicate code.

What changes are included in this PR?

  • Refactor proxy write.
  • Refactor proxy route.
  • Move some code to proxy.

Are there any user-facing changes?

No.

How does this change test

CI.

@chunshao90 chunshao90 changed the title refactor: proxy write refactor: proxy write and route May 11, 2023
@chunshao90 chunshao90 marked this pull request as ready for review May 11, 2023 07:25
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit def0f96 into apache:main May 12, 2023
5 checks passed
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants