Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: proxy sql read #896

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented May 16, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Refactor the proxy module to remove some duplicate code.

What changes are included in this PR?

  • Refactor proxy sql query.

Are there any user-facing changes?

No.

How does this change test

CI.

@chunshao90 chunshao90 force-pushed the refactor-proxy-query branch 2 times, most recently from c33c221 to a386fba Compare May 16, 2023 08:36
@chunshao90 chunshao90 marked this pull request as ready for review May 16, 2023 08:38
@jiacai2050 jiacai2050 self-requested a review May 16, 2023 08:50
proxy/src/read.rs Show resolved Hide resolved
proxy/src/read.rs Show resolved Hide resolved
integration_tests/cases/env/local/ddl/create_tables.result Outdated Show resolved Hide resolved
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 1d08bd6 into apache:main May 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants