Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tokio console for debugging #909

Merged
merged 3 commits into from
May 22, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented May 22, 2023

Related Issues

Closes #

Detailed Changes

  • Add console subcriber to tracing.
  • Add related configs to decide whether open with tokio console server.
  • Modify makefile to support build with unstable tokio.

Test Plan

Test manually.

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 8893478 into apache:main May 22, 2023
5 checks passed
@Rachelint Rachelint deleted the support-tokio-console branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants