Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace DefaultHash with AHasher #928

Merged
merged 6 commits into from
May 24, 2023
Merged

chore: replace DefaultHash with AHasher #928

merged 6 commits into from
May 24, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented May 24, 2023 •
edited by ShiKaiWi

Related Issues

Closes #921

Detailed Changes

Replace the hash algorithm from DefaultHasher to ahash for better performance in partition lock.

Test Plan

Time cost to compute hash on a 10-char string:

  • DefaultHash: 10: 33.6364 ns
  • ahash: 10: 19.0412 ns
  • murmur3: 10: 33.0394 ns

jiacai2050
jiacai2050 approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 changed the title chore: import ahash chore: replace DefaultHash with AHasher May 24, 2023
@jiacai2050 jiacai2050 merged commit 8fe556c into apache:main May 24, 2023
5 checks passed
@tanruixiang tanruixiang deleted the add_ahash branch June 13, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a Hasher based on murmur3
2 participants
@tanruixiang @jiacai2050