Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing metrics when using chain iterator #964

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Jun 2, 2023

Rationale

The metrics about scan is missing when chain iterator is used underlying.

Detailed Changes

Do metrics collection when using chain iterator.

Test Plan

Manually.

Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit e64c628 into apache:main Jun 2, 2023
5 checks passed
@ShiKaiWi ShiKaiWi deleted the fix-missing-metrics-for-chain-iter branch June 2, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants