Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: disk cache use partition lock #974

Merged
merged 15 commits into from
Jun 7, 2023

Conversation

tanruixiang
Copy link
Member

@tanruixiang tanruixiang commented Jun 7, 2023

Rationale

Close #914

Detailed Changes

Use partition lock in disk cache

Test Plan

add ut.

@jiacai2050 jiacai2050 self-requested a review June 7, 2023 02:37
@tanruixiang tanruixiang marked this pull request as ready for review June 7, 2023 03:07
common_util/src/partitioned_lock.rs Show resolved Hide resolved
components/object_store/src/disk_cache.rs Outdated Show resolved Hide resolved
components/object_store/src/disk_cache.rs Show resolved Hide resolved
common_util/src/partitioned_lock.rs Show resolved Hide resolved
analytic_engine/src/setup.rs Outdated Show resolved Hide resolved
common_util/src/partitioned_lock.rs Outdated Show resolved Hide resolved
components/object_store/src/disk_cache.rs Outdated Show resolved Hide resolved
components/object_store/src/disk_cache.rs Outdated Show resolved Hide resolved
components/object_store/src/disk_cache.rs Outdated Show resolved Hide resolved
@tanruixiang tanruixiang force-pushed the disk_cache_use_partition_lock branch from 3efb2f9 to 39bc0eb Compare June 7, 2023 07:45
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 changed the title Disk cache use partition lock refactor: disk cache use partition lock Jun 7, 2023
@jiacai2050 jiacai2050 merged commit 25899eb into apache:main Jun 7, 2023
5 checks passed
@tanruixiang tanruixiang deleted the disk_cache_use_partition_lock branch June 13, 2023 11:48
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Close apache#914

## Detailed Changes
Use `partition lock` in `disk cache`

## Test Plan
add ut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use partitioned lock to optimize disk cache
2 participants