Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: function args of object store #978

Merged
merged 4 commits into from
Jun 9, 2023
Merged

refactor: function args of object store #978

merged 4 commits into from
Jun 9, 2023

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Jun 8, 2023

Rationale

Simplified code

Detailed Changes

  • replace Aliyun fn args with AliyunOptions
  • replace S3 fn args with S3Options

Test Plan

Existing tests

jiacai2050
jiacai2050 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 3c2a05a into apache:main Jun 9, 2023
5 checks passed
@baojinri baojinri deleted the refactor-object-store-args branch June 19, 2023 02:05
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
@baojinri @dust1
refactor: function args of object store (apache#978)
be98b3e 
## Rationale
Simplified code

## Detailed Changes
- replace Aliyun fn args with AliyunOptions
- replace S3 fn args with S3Options

## Test Plan
Existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baojinri @jiacai2050