Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deny dbg-macro in clippy #983

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Jun 9, 2023

Rationale

clippy::dbg-macro lint default to allow in clippy, but we want it to be denied.

Detailed Changes

Add -D clippy::dbg-macro when running cargo clippy.

Test Plan

Not need.

@Rachelint Rachelint changed the title chore: remove useless dbg macro chore: deny dbg-macro in clippy Jun 9, 2023
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 3ad8b12 into apache:main Jun 9, 2023
5 checks passed
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
`clippy::dbg-macro` lint default to allow in clippy, but we want it to
be denied.

## Detailed Changes
Add `-D clippy::dbg-macro` when running `cargo clippy`.

## Test Plan
Not need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants