Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add grpc handler metrics #988

Merged

Conversation

baojinri
Copy link
Contributor

@baojinri baojinri commented Jun 12, 2023

Rationale

Add grpc query success counter metrics.

Detailed Changes

  • Add counter metric in grpc proxy.
  • Add counter metric in grpc remote engine service.

Test Plan

Existing tests.

@chunshao90
Copy link
Contributor

Add counter for write_succeeded and query_failed.

@baojinri baojinri changed the title refactor: add grpc query success counter metrics refactor: add grpc handler metrics Jun 14, 2023
proxy/src/grpc/sql_query.rs Outdated Show resolved Hide resolved
proxy/src/grpc/sql_query.rs Outdated Show resolved Hide resolved
server/src/grpc/remote_engine_service/mod.rs Outdated Show resolved Hide resolved
proxy/src/grpc/metrics.rs Outdated Show resolved Hide resolved
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 77d0d79 into apache:main Jun 16, 2023
6 checks passed
@baojinri baojinri deleted the refactor-add-grpc-query-success-counter branch June 19, 2023 02:05
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Add grpc query success counter metrics.

## Detailed Changes
- Add counter metric in grpc proxy.
- Add counter metric in grpc remote engine service.

## Test Plan
Existing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants