refactor: avoid grpc forwarding twice #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baojinri
commented
Jun 14, 2023
ShiKaiWi
changed the title
baojinri
force-pushed
the
refactor-avoid-grpc-continuous-forwarding
branch
from
3cd9210
to
85d0a10
Compare
ShiKaiWi
reviewed
Jun 16, 2023
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
## Rationale Close apache#984 ## Detailed Changes Add a parameter to the headers of grpc to mark that it has been forwarded. ## Test Plan Existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Close #984
Detailed Changes
Add a parameter to the headers of grpc to mark that it has been forwarded.
Test Plan
Existing tests