Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install git in Dockerfile #992

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jun 13, 2023

Rationale

git version is missing in docker

Detailed Changes

Install git in Dockerfile

Test Plan

https://github.com/CeresDB/ceresdb/actions/runs/5252618309

root@35379a134476:/# ceresdb-server --version
CeresDB Server 
Version: 1.2.2
Git commit: 5c63d19
Git branch: fix-version
Opt level: 3

Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit bf75c13 into apache:main Jun 14, 2023
7 checks passed
@jiacai2050 jiacai2050 deleted the fix-version branch June 14, 2023 06:51
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
git version is missing in docker

## Detailed Changes
Install git in Dockerfile

## Test Plan

https://github.com/CeresDB/ceresdb/actions/runs/5252618309
```
root@35379a134476:/# ceresdb-server --version
CeresDB Server 
Version: 1.2.2
Git commit: 5c63d19
Git branch: fix-version
Opt level: 3
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants