Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of this library/npm package/TypeScript definition #144

Open
ca057 opened this issue Jan 5, 2021 · 1 comment
Open

Status of this library/npm package/TypeScript definition #144

ca057 opened this issue Jan 5, 2021 · 1 comment

Comments

@ca057
Copy link

ca057 commented Jan 5, 2021

Hey! 馃憢

I was wondering about the status of this library and the related npm packages, currently there are two both pointing to this repo:

Do I assume correct that the latter one is the one we should use when using this library? But if I see it correctly in the node_modules, the latter version does not export TimePicker and DatePicker - are those two pickers removed? We should then update the documentation, as this can be confusing.
In addition, it seems the TypeScript definitions are not picked up properly:

When I import the WheelPicker as following:

import { WheelPicker } from '@victorzimnikov/react-native-wheel-picker-android';

I receive an error from TypeScript stating Module '"node_modules/@victorzimnikov/react-native-wheel-picker-android"' has no exported member 'WheelPicker'. I assume this is the case as the export in index.js (export * from "./src/WheelPicker";) relies on the platform specific distinction performed by React Native which TypeScript won鈥檛 do. Is there any work already going on to fix those definitions or is this something where I can jump in?

Thanks!

EDIT:
I have the feeling the other library I found on npm is not the right one we should use, but a temporary hack to have a newer version? Is it possible to publish an update of this npm package (react-native-wheel-picker-android) to npm, so we benefit e.g. from the switch to the picker of react-native-community?

@torufuruya
Copy link

Can we have any updates on this topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants