Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectedItemTextFontFamily and itemTextFontFamily props should be optional #183

Open
balsick opened this issue Jul 12, 2023 · 0 comments
Open

Comments

@balsick
Copy link

balsick commented Jul 12, 2023

Hi! 馃憢

Today I used patch-package to patch react-native-wheel-picker-android@2.0.6 for the project I'm working on.

While most props are set as optional, selectedItemTextFontFamily and itemTextFontFamily don't, but considering the README and the normal usage of the component, they should be set optional as well.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-wheel-picker-android/index.d.ts b/node_modules/react-native-wheel-picker-android/index.d.ts
index 70a48e9..6daabe3 100644
--- a/node_modules/react-native-wheel-picker-android/index.d.ts
+++ b/node_modules/react-native-wheel-picker-android/index.d.ts
@@ -4,10 +4,10 @@ import { DatePickerIOSProps, StyleProp, ViewStyle } from 'react-native';
 interface IStyle {
 	selectedItemTextColor?: string;
 	selectedItemTextSize?: number;
-	selectedItemTextFontFamily: string;
+	selectedItemTextFontFamily?: string;
 	itemTextColor?: string;
 	itemTextSize?: number;
-	itemTextFontFamily: string;
+	itemTextFontFamily?: string;
 	indicatorColor?: string;
 	hideIndicator?: boolean;
 	indicatorWidth?: number;

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant