Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winner manipulation spec #13

Open
Czar102 opened this issue Sep 28, 2023 · 4 comments
Open

Winner manipulation spec #13

Czar102 opened this issue Sep 28, 2023 · 4 comments
Labels
Acknowledged valid solution - eligible for reward

Comments

@Czar102
Copy link

Czar102 commented Sep 28, 2023

Hi, displaying info below:

pr: #12

A run of the new BordaMissingRule.spec on the original Borda.sol that is verified is here

A run of Borda.spec on BordaNewBug.sol showing the existing spec misses the bug is here

Reports of all previously acknowledged bounty specs on BordaNewBug.sol, these specs will be found in the bounty_specs folder: included in the previous verification, see votedFunctionIsVotedMapping

A run of BordaMissingRule.spec on BordaNewBug.sol showing your rule catches the bug is here

Thanks for the challenge again!

@nd-certora
Copy link
Contributor

can you please check if this is covered by
#7

@Czar102
Copy link
Author

Czar102 commented Sep 28, 2023

This is for sure partially covered by #7, I will check if I can produce an implementation that passes spec in #7 but fails this spec.

@Czar102
Copy link
Author

Czar102 commented Sep 28, 2023

The BordaNewBug.sol from the above verification in an example of a contract compliant with spec in #7, but where a vote manipulation is caught by this rule.
cc @imsrybr0

edit. demonstrated here

@nd-certora
Copy link
Contributor

very interesting mutation, agree that it is not covered by the previous missing spec . Acknowledged as #3

@nd-certora nd-certora added the Acknowledged valid solution - eligible for reward label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged valid solution - eligible for reward
Projects
None yet
Development

No branches or pull requests

2 participants