Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid view function reverts #17

Open
Czar102 opened this issue Sep 28, 2023 · 1 comment
Open

Forbid view function reverts #17

Czar102 opened this issue Sep 28, 2023 · 1 comment
Labels
Acknowledged valid solution - eligible for reward

Comments

@Czar102
Copy link

Czar102 commented Sep 28, 2023

Hi, displaying info below:

pr: #16

A run of the new BordaMissingRule.spec on the original Borda.sol that is verified is here

A run of Borda.spec on BordaNewBug.sol showing the existing spec misses the bug is here

Reports of all previously acknowledged bounty specs on BordaNewBug.sol: included in the above verification, see votedFunctionIsVotedMapping, preferLastVotedHigh and onlyVotingCanChangeTheWinner.

A run of BordaMissingRule.spec on BordaNewBug.sol showing your rule catches the bug is here

Thanks for the challenge yet again!

@nd-certora
Copy link
Contributor

Indeed, reverting view functions can impact the winner. acknowledged as the fifth and last missing spec

@nd-certora nd-certora added the Acknowledged valid solution - eligible for reward label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged valid solution - eligible for reward
Projects
None yet
Development

No branches or pull requests

2 participants