You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The dropAll Overwrite will affect the behaviour of any mod that calls the method directly. It would probably be better to leave the original method intact and redirect the call in PlayerEntity#dropInventory instead.
The text was updated successfully, but these errors were encountered:
Pyrofab
changed the title
Inventory#dropAll overwrite may break mods' expectations
Inventory#dropAll overwrite may break mods' expectations
Jan 30, 2020
Looks fine ! But I would recommend using At#target instead of At#ordinal to select the redirected method call. It would be less likely to break, and would make the code clearer.
The
dropAll
Overwrite will affect the behaviour of any mod that calls the method directly. It would probably be better to leave the original method intact and redirect the call inPlayerEntity#dropInventory
instead.The text was updated successfully, but these errors were encountered: