Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tileset JSON is not zipped when running gzip #22

Closed
javagl opened this issue Apr 20, 2023 · 2 comments · Fixed by #24
Closed

The tileset JSON is not zipped when running gzip #22

javagl opened this issue Apr 20, 2023 · 2 comments · Fixed by #24

Comments

@javagl
Copy link
Contributor

javagl commented Apr 20, 2023

The previous version of the tools contained a mechanism for some operations that caused the tileset.json to be written in zipped form when it was zipped in the input, and to be written in non-zipped form when it was not zipped in the input. (See, for example, the previous combineTilesets function).

The current state of the tools tried to emulate this behavior, by keeping track of whether the input tileset.json was zipped. This causes a bug where the tileset.json will not be zipped, even when running gzip.

To solve this: The zippedness of the input should not matter. The tools should always be able to read zipped input, but write the output in un-zipped form, unless zipping was the actual operation that should be performed. This can either be via the gzip command, or via a gzip pipeline stage.

(The (legacy) tilesOnly flag for the gzip operation has to be taken into account here, but that has already been generalized, and should be easy to handle)

@javagl
Copy link
Contributor Author

javagl commented May 20, 2023

I'll reopen this as a reminder that the legacy behavior of
if (inputWasZipped) writeZipped(output) else write(output)
is still applied in the TilesetUpgrader.

The upgrade functionality is addressed, in a far broader sense, in #5 , and this will also affect this aspect of the behavior.

@javagl javagl reopened this May 20, 2023
@javagl
Copy link
Contributor Author

javagl commented Aug 8, 2023

The TilesetUpgrader has been updated in #41 and does now no longer try to track the compression status of the entries.

@javagl javagl closed this as completed Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant