Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator - validateB3dm header #9

Closed
lilleyse opened this issue Oct 4, 2016 · 5 comments
Closed

Validator - validateB3dm header #9

lilleyse opened this issue Oct 4, 2016 · 5 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Oct 4, 2016

@JudyWeng

Write a lib file called validateB3dm that takes a Buffer containing the contents of a b3dm (like as returned by readTile) and checks that it is valid according the the b3dm spec. For now just check that:

magic is "b3dm"
version is 1
byteLength is equal to the Buffer's length
batchTableJSONByteLength - skip for now, will require more validation later
batchTableBinaryByteLength - skip for now, will require more validation later
batchLength - skip for now, this is dependent on the glTF within the b3dm

This issue will get more involved and will eventually extend to the other tile formats.

@pjcozzi pjcozzi mentioned this issue Oct 4, 2016
53 tasks
@JudyWeng
Copy link
Contributor

JudyWeng commented Oct 8, 2016

I tried to push earlier and it says I do not have access to 3d-tiles-tools. Am I supposed to push elsewhere?

@lilleyse
Copy link
Contributor Author

lilleyse commented Oct 8, 2016

Did you receive any emails about being added to the organization?

@JudyWeng
Copy link
Contributor

JudyWeng commented Oct 8, 2016

oh sorry, yeah, it went to my spam box for some reason. Thanks!

@JudyWeng JudyWeng mentioned this issue Oct 13, 2016
@lilleyse
Copy link
Contributor Author

lilleyse commented Nov 1, 2016

Fixed in #14

@lilleyse lilleyse closed this as completed Nov 1, 2016
@lilleyse
Copy link
Contributor Author

lilleyse commented Nov 1, 2016

And #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants