Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voxel artifacts with infinitely thin shapes #11017

Open
lilleyse opened this issue Jan 4, 2023 · 0 comments
Open

Voxel artifacts with infinitely thin shapes #11017

lilleyse opened this issue Jan 4, 2023 · 0 comments

Comments

@lilleyse
Copy link
Contributor

lilleyse commented Jan 4, 2023

The voxel code allows for creating infinitely thin shapes, which is a handy feature for inspecting individual slices of voxel data. There are some artifacts though:

  • When making a shape infinitely thin via min/maxBounds it always renders the front side. Instead it should render just the side that was hit. This happens for most shape types. Note: this bug only happens for min/maxBounds, not min/maxClippingBounds. See message previously in convertUvToEllipsoid.glsl:
    #if defined(ELLIPSOID_HAS_SHAPE_BOUNDS_HEIGHT_FLAT)
        // TODO: This breaks down when minBounds == maxBounds. To fix it, this
        // function would have to know if ray is intersecting the front or back of the shape
        // and set the shape space position to 1 (front) or 0 (back) accordingly.
        float height = 1.0;

thin-box

  • Ellipsoids only render one side of the shape when the latitude range is zero. This happens for both min/maxBounds and min/maxClippingBounds.

ezgif com-gif-maker (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant